Replace JAVA_BIN with TEST_JDK_HOME #5744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviewer: @llxia |
|
Copyright check failed for |
- expect user to export TEST_JDK_HOME instead of JAVA_BIN - figure out where JAVA_BIN is based on JDK_VERSION - remove JDK_HOME, replace it with TEST_JDK_HOME - remove JAVA_BIN_TMP - update readme [ci skip] Signed-off-by: Renfei Wang <renfeiw@ca.ibm.com>
|
We delivered a couple of changes for TKG into master. Since these changes (i.e., run and list disabled tests) do not affect regular builds, we will only deliver the Thanks @renfeiw for testing internally. |
|
fyi @pshipton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip]
Signed-off-by: Renfei Wang renfeiw@ca.ibm.com