(v0.14.2) Declare J9RAMVirtualMethodRef methodIndexAndArgCount as volatile #5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declaring J9RAMVirtualMethodRef.methodIndexAndArgCount as volatile instructs the compiler to generate assembly code that writes to the field atomically. This fixes the segment error due to zero methodIndex which seems due to separated writes to the field, first one is argCount, and the second one is methodIndex. In addition, the field J9RAMVirtualMethodRef.method is declared as volatile as well. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
pshipton
approved these changes
May 10, 2019
pshipton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare
J9RAMVirtualMethodRef methodIndexAndArgCountasvolatileDeclaring
J9RAMVirtualMethodRef.methodIndexAndArgCountasvolatileinstructs the compiler to generate assembly code that writes to the field atomically.This fixes the segment error due to
zero methodIndexwhich seems due to separated writes to the field, first one isargCount, and the second one ismethodIndex.In addition, the field
J9RAMVirtualMethodRef.methodis declared asvolatileas well.More background info is at #4778 (comment)
Backported from #5694
Reviewer: @pshipton
Signed-off-by: Jason Feng fengj@ca.ibm.com