(v0.14.0-release) Set JVM_INTERFACE_VERSION to 5 for JDK12.0.1 #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDK12.0.1 doesn't have the change (JVM_INTERFACE_VERSION = 6) like JDK 11.0.3, 12.0.2 and 13. Set JVM_INTERFACE_VERSION to 5 for JDK12.0.1 (Release 0.14.0 branch). Signed-off-by: Jason Feng <fengj@ca.ibm.com>
pshipton
approved these changes
Apr 18, 2019
pshipton
modified the milestones:
Release 0.14.0 (Java 8, 11, 12) April refresh,
Release 0.14.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
JVM_INTERFACE_VERSIONto5forJDK12.0.1JDK12.0.1doesn't have the change (JVM_INTERFACE_VERSION = 6) likeJDK 11.0.3, 12.0.2 and 13.Set
JVM_INTERFACE_VERSIONto5forJDK12.0.1(Release 0.14.0 branch).This code was tested before, travis build is sufficient for sanity check.
closes: #5553
Reviewer: @pshipton
Signed-off-by: Jason Feng fengj@ca.ibm.com