Final prep for milestone 1 #5355
Merged
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add jstack (8,11,12) and jps (8,11) to complete all content ready at MS1. Signed-off-by: Sue Chaplain <sue_chaplain@uk.ibm.com>
|
@pshipton I'm out until after MS1, so if there are any other changes needed these will have to be done on top of my merge, or in a separate PR. |
pshipton
reviewed
Apr 4, 2019
| <td valign="top">Ability to obtain Java stack traces and thread information for processes.</td> | ||
| </tr> | ||
|
|
||
| <tr><td valign="top"><a href="https://github.com/eclipse/openj9/issues/4655">#4655</a></td> |
There was a problem hiding this comment.
Although everything else is an issue and not a PR. I was going to change it, but I think I'll just leave it be.
pshipton
approved these changes
Apr 4, 2019
|
Nit: inconsistent formatting: |
@pdbain-ibm given #5355 (comment) , if you want this fixed, please create a PR with the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add jstack (8,11,12) and jps (8,11) to complete
all content ready at MS1.
Signed-off-by: Sue Chaplain sue_chaplain@uk.ibm.com