Return NULL instead of throwing when the class name is invalid #5284
+36
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test sanity plinux jdk8,jdk11,jdk12 |
gacholio
reviewed
Mar 28, 2019
gacholio
reviewed
Mar 28, 2019
Prior to eclipse-openj9#4919, ClassLoader.defineClassImpl() would check if the given class name and immediately throw NoClassDefFoundError if it was invalid. Beginning with Java 12, JavaLangAccess.defineClass() is used to define accessor classes (with invalid names). The name validation must still be done, but throwing the exception must be delayed until it can be determined to be the appropriate response. The invalid name is signalled with a bit in the options parameter to defineClassCommon() which must not set a pending exception in that case. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
Updated based on review feedback. |
|
Jenkins test sanity plinux jdk8,jdk11,jdk12 |
gacholio
approved these changes
Mar 28, 2019
|
@keithc-ca please create a PR for the 0.14 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #4919, ClassLoader.defineClassImpl() would check if the given
class name and immediately throw NoClassDefFoundError if it was invalid.
Beginning with Java 12, JavaLangAccess.defineClass() is used to define
accessor classes (with invalid names). The name validation must still
be done, but throwing the exception must be delayed until it can be
determined to be the appropriate response. The invalid name is signalled
with a bit in the options parameter to defineClassCommon() which must
not set a pending exception in that case.