Add IgnoreDecimalOverflowException codegen flag #5166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test sanity zlinux JDK8 |
0xdaryl
requested changes
Mar 19, 2019
| @@ -178,6 +178,8 @@ J9::Z::CodeGenerator::CodeGenerator() : | |||
| { | |||
| self()->setHasFixedFrameC_CallingConvention(); | |||
| } | |||
|
|
|||
| setIgnoreDecimalOverflowException(false); | |||
| * Determines whether decimal overflow or fixed point overflow checks should be generated for instructions which | ||
| * support such by-passes. | ||
| */ | ||
| bool ignoreDecimalOverflowException; |
There was a problem hiding this comment.
Other classes use a preceding _ for private fields (though arguably it isn't super consistent throughout the code base). Just pointing it out though.
This codegen flag determines whether decimal overflow or fixed point overflow checks should be generated for instructions which support such by-passes. Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
|
Jenkins test sanity zlinux JDK8 |
0xdaryl
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This codegen flag determines whether decimal overflow or fixed point
overflow checks should be generated for instructions which support such
by-passes.
Signed-off-by: Filip Jeremic fjeremic@ca.ibm.com