Improve the error reporting when j9shmem_getDir() failed.

[hangshao0]

1. Change j9shmem_getDir() to return different error code for different
   failures.
2. Change the caller of j9shmem_getDir()to print new NLS messages
   according to the error code returned from j9shmem_getDir().
3. Update the test code to check if j9shmem_getDir() returns a negative
   value instead of -1.

Fixes #5134

Signed-off-by: Hang Shao hangshao@ca.ibm.com

[hangshao0]

Manually set HOME to NFS:

java -Xshareclasses:name=Cache1 -version
JVMSHRC831E Failed to use user's home as the default shared cache directory. It is on a Network File System. Please set another directory via environment variable "HOME" or fix the home directory in the password file entry.
JVMSHRC831E Failed to use user's home as the default shared cache directory. It is on a Network File System. Please set another directory via environment variable "HOME" or fix the home directory in the password file entry.
JVMJ9VM015W Initialization error for library j9shr29(11): JVMJ9VM009E J9VMDllMain failed
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

java -Xshareclasses:name=Cache1,silent -version
JVMJ9VM015W Initialization error for library j9shr29(11): JVMJ9VM009E J9VMDllMain failed
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

java -Xshareclasses:name=Cache1,nonfatal -version
JVMSHRC831E Failed to use user's home as the default shared cache directory. It is on a Network File System. Please set another directory via environment variable "HOME" or fix the home directory in the password file entry.
JVMSHRC831E Failed to use user's home as the default shared cache directory. It is on a Network File System. Please set another directory via environment variable "HOME" or fix the home directory in the password file entry.
JVMSHRC686I Failed to startup shared class cache. Continue without using it as -Xshareclasses:nonfatal is specified
openjdk version "1.8.0_202-internal"
OpenJDK Runtime Environment (build 1.8.0_202-internal-jenkins_2019_03_18_14_23-b00)
Eclipse OpenJ9 VM (build FixSCC-a41867c5f, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20190318_863 (JIT enabled, AOT enabled)
OpenJ9   - 9f1746bad
OMR      - 9b73e2bd
JCL      - 6894a182ad1 based on jdk8u202-b08)

The reason JVMSHRC831E shows up twice is because we try getting the cache dir both in checkIfCacheExists() and SH_OSCache::commonStartup(). Without this change, there were also 2 NLS messages printed out in checkIfCacheExists() and SH_OSCache::commonStartup().

[pshipton]

Is it much work to fix the error to only print once?

[hangshao0]

Is it much work to fix the error to only print once?

We need to change the signature of SH_OSCache::getCacheDir() to control whether the NLS messages should be printed. There are about 20 callers.

[pshipton]

jenkins test sanity win,plinux jdk11

[pshipton]

We need to change the signature of SH_OSCache::getCacheDir() to control whether the NLS messages should be printed. There are about 20 callers.

Seems better done separately.

[keithc-ca]

This condition will always be false.

• @internal J9PORT_ERROR_SHMEM* range from at -170 to -199 to match hyporterror.h codes.

[pshipton]

I think that is intentional? If it did happen we'd hit the assert.

[pshipton]

j9shr_getCacheDir() and SH_OSCache::getCacheDir() returns -1 on failure. I think the assert needs to be removed.

[hangshao0]

I will remove this assert in the next PR.

[hangshao0]

PR: #5202

[keithc-ca]

Sorry, I thought it was still using j9shmem_getDir(). I need to learn to read more carefully.

[pshipton]

You found a problem anyway :)