Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge methods should also be 'synthetic' #5104

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

keithc-ca
Copy link
Contributor

Without the synthetic bit, eclipse treats bridge methods as if they introduce ambiguity.
The intent is to put the generated classes in a jar that can be on the classpath for the DDR_VM project.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@DanHeidinga
Copy link
Member

@keithc-ca Any suggestions on the right level of PR build for this change?

Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@DanHeidinga DanHeidinga self-assigned this Mar 14, 2019
@keithc-ca
Copy link
Contributor Author

@keithc-ca Any suggestions on the right level of PR build for this change?

I don't expect this to affect anything yet. The old pointer class generator is still being used at build time and pointers are not yet created dynamically at runtime. Even just a basic compile should be sufficient.

@DanHeidinga
Copy link
Member

Jenkins compile xlinux jdk8

@DanHeidinga DanHeidinga merged commit a32086c into eclipse-openj9:master Mar 15, 2019
@keithc-ca keithc-ca deleted the synthetic branch March 15, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants