Adopt Java 12 jdk.internal.reflect.Reflection & ASM requirement #5103
Conversation
| @@ -0,0 +1,53 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 20019, 2019 IBM Corp. and others | |||
|
we need to update copyright for |
Added source directories src_java12 for Java 12 and src_java8 for earlier versions; Cmvc196982 is modified for Java 12 to get field values via package access method reflection instead of direct field reflection which is prohibited since Java 12; Updated jdk.internal.org.objectweb.asm.Opcodes.ASM4/ASM5 to ASM7 for Java 12; Enabled previously disabled tests for Java 12. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
JasonFengJ9
force-pushed
the
flushreflection
branch
from
94bca47 to
6511af0
Compare
|
I don't understand how these changes fix #4658 @JasonFengJ9 any idea why your Eclipse ECA check is failing? Do you need to sign a new agreement? |
|
It seems so though there was an email (Mar 9th) stated that it will expire in 14 days. |
|
Jason explained the change is in test/functional/JavaAgentTest/src_java12/org/openj9/test/javaagenttest/Cmvc196982.java |
It is the compilation issue. Earlier |
|
jenkins test sanity plinux jdk11,jdk12 |
|
jenkins test extended plinux jdk11,jdk12 |
pshipton
dismissed
keithc-ca’s stale review
The ASM7 constant doesn't exist in Java 8.
Adopt
Java 12 jdk.internal.reflect.Reflection&ASMrequirementAdded source directories
src_java12forJava 12andsrc_java8for earlier versions;Cmvc196982is modified forJava 12to get field values via package access method reflection instead of direct field reflection which is prohibited sinceJava 12;Updated
jdk.internal.org.objectweb.asm.Opcodes.ASM4/ASM5toASM7forJava 12;Enabled previously disabled tests for
Java 12.Verified manually that this PR passes the tests in #4658 and #4663
closes: #4658
closes: #4663
Reviewers: @pshipton @llxia
FYI: @DanHeidinga
Signed-off-by: Jason Feng fengj@ca.ibm.com