(0.13.0) Fix VarHandleDesc constructor setup #5076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix logic error in VarHandle.VarHandleDesc.Kind.getBootstrap - fix VarHandleDesc constructor superclass call to DynamicConstantDesc - remove declaringClassDesc field in VarHandleDesc. This information can be retrieved from the superclass bootstrap arguments - add private helper methods to retrieve information from superclass bootstrap arguments - add additional tests for DynamicConstantDesc to VarHandle description <-> resolution Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
DanHeidinga
changed the title
|
PR against master branch merged. Merging into 0.13 now |
DanHeidinga
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delivering #5003 for 0.13
This adds the entire Test_DynamicConstantDesc file and testng entry since #4873 was not delivered to 0.13
Signed-off-by: Theresa Mammarella Theresa.T.Mammarella@ibm.com
@DanHeidinga