Fix incorrect iTable build #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iTable building code was considering all methods in the interface class, not just the ones that are appropriate for the iTable. This results in an incorrect iTable shape (and very possibly writing off the end of the allocated iTable chunk). Process only methods from the interface which make up the interface contract (public methods that appear in the vTable). [ci skip] Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
|
jenkins test sanity xlinux jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iTable building code was considering all methods in the interface
class, not just the ones that are appropriate for the iTable. This
results in an incorrect iTable shape (and very possibly writing off the
end of the allocated iTable chunk).
Process only methods from the interface which make up the interface
contract (public methods that appear in the vTable).
[ci skip]
Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com