Modifty Metronome.hpp for moving into OMR #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <jasonhal@ca.ibm.com>
|
|
||
| #include <assert.h> | ||
| #define ASSERT_LEVEL 0 | ||
| #define assert1(expr) assert((ASSERT_LEVEL < 1) || (expr)); | ||
| #define assert2(expr) assert((ASSERT_LEVEL < 2) || (expr)); | ||
|
|
||
| #define MAX_UINT ((UDATA) (-1)) | ||
| #define MAX_UINT ((uintptr_t) (-1)) |
There was a problem hiding this comment.
This definition exists in OMR code already in AllocationContextSegregated.cpp
Also OMR has UDATA_MAX definition for this used widely.
Also there are multiple places in the code with ((uintptr_t) (-1)) and ((UDATA) (-1))
@charliegracie I wondering may be it is time to do cleanup and use single proper definition everywhere (done by two separate PRs - one for OMR another for OpenJ9) ?
dmitripivkine
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Hall jasonhal@ca.ibm.com