Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculateFieldDataStart in flat field case #5057

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

tajila
Copy link
Contributor

@tajila tajila commented Mar 11, 2019

Fix calculateFieldDataStart in flat field case

Fix the calculateFieldDataStart code to account for flattened
fields that contain doubles.

Signed-off-by: tajila atobia@ca.ibm.com

@tajila
Copy link
Contributor Author

tajila commented Mar 11, 2019

@gacholio Please review these changes

Copy link
Contributor

@gacholio gacholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable - I'll ask again if DDR has been updated to understand the flattened layouts.

@gacholio
Copy link
Contributor

jenkins test sanity xlinux jdk12

Fix the `calculateFieldDataStart` code to account for flattened 
fields that contain doubles.

Signed-off-by: tajila <atobia@ca.ibm.com>
@gacholio
Copy link
Contributor

Earlier testing was sufficient so I'm not launching any more.

@gacholio gacholio merged commit 98f41b3 into eclipse-openj9:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants