Revise tree pattern used to match inline finalizable test #5009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern used to match an inline finalizable test might be incorrect in 64-bit mode as tree simplification might result in 32-bit operations being used. This change accounts for that possibility by checking whether an l2i was applied to the result of the load of isClassAndDepthFlags, and checks for 32-bit operations accordingly. Fixes: Issue eclipse-openj9#4885 Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
pshipton
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern used to match an inline finalizable test might be incorrect in 64-bit mode as tree simplification might result in 32-bit operations being used. This change accounts for that possibility by checking whether an l2i was applied to the result of the load of isClassAndDepthFlags, and checks for 32-bit operations accordingly.
Fixes: Issue #4885
Deliver #4891 to the 0.13 branch
Signed-off-by: Henry Zongaro zongaro@ca.ibm.com