(v0.13.0-release) VarargsCollectorHandle.asType throws WrongMethodTypeException #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert IllegalArgumentException to WrongMethodTypeException within VarargsCollectorHandle.asType(). Signed-off-by: Jason Feng <fengj@ca.ibm.com>
DanHeidinga
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VarargsCollectorHandle.asType()throwsWrongMethodTypeExceptionConvert
IllegalArgumentExceptiontoWrongMethodTypeExceptionwithinVarargsCollectorHandle.asType().This PR passes the test within #4937.
Note: Java doc states that
java.lang.invoke.MethodHandlecan throwsNullPointerExceptionif newType is anullreference orWrongMethodTypeExceptionif the conversion cannot be made. There is noIllegalArgumentExceptionthrown.It appears there are other cases that
IllegalArgumentExceptionmight be thrown. I would like to leave it as is for now since no test complains or another PR if required.Ported from #4977
Reviewer: @DanHeidinga
Signed-off-by: Jason Feng fengj@ca.ibm.com