-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update makeGen to use standard XML parser #499
Conversation
reviewer: @llxia |
Please make sure to update Prerequisites in the readme file. |
Signed-off-by: Renfei Wang <renfeiw@ca.ibm.com>
We are still waiting for perl XML::Parser module to be installed on all machines. |
Blocked by infra issue (/runtimes/tooling/issues/290). |
This is not a mandotory, the current parsing code (written by ourselves) works without any problem so far. But it may require more effort to add any new parsing feature. To utilize the standard parser, we need to have perl XML::Parser module installed on all the machines. @AdamBrousseau Do we already have it installed? |
I see XML Parser in the Adopt Unix playbooks here. So it may be on some machines. I recall an issue on this a while back. I could try and dig it up. We would have to verify all the machines have it. I assume it would be needed on any machine we compile test material on, ie. any machine we test on. |
@AdamBrousseau Do you have any update on this? We would like to use the standard XML parser. Thanks. |
I don't think it is installed on all the machines. Please open an issue at Adopt/openjdk-infrastructure to add it to the remaining playbooks. |
Change is merged in #4785 |
Signed-off-by: Renfei Wang renfeiw@ca.ibm.com