Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update makeGen to use standard XML parser #499

Closed
wants to merge 1 commit into from

Conversation

renfeiw
Copy link
Contributor

@renfeiw renfeiw commented Nov 1, 2017

Signed-off-by: Renfei Wang renfeiw@ca.ibm.com

@renfeiw
Copy link
Contributor Author

renfeiw commented Nov 1, 2017

reviewer: @llxia

@llxia
Copy link
Contributor

llxia commented Nov 1, 2017

Please make sure to update Prerequisites in the readme file.

Signed-off-by: Renfei Wang <renfeiw@ca.ibm.com>
@mstoodle
Copy link
Contributor

mstoodle commented Feb 1, 2018

@renfeiw @llxia what's the current status here, please?

@renfeiw
Copy link
Contributor Author

renfeiw commented Feb 1, 2018

We are still waiting for perl XML::Parser module to be installed on all machines.

@renfeiw renfeiw changed the title Update makeGen to use standard XML parser WIP: Update makeGen to use standard XML parser Feb 1, 2018
@smlambert
Copy link
Contributor

Blocked by infra issue (/runtimes/tooling/issues/290).

@DanHeidinga
Copy link
Member

@renfeiw @llxia Is this still relevant? If so can we get it finished off?

@renfeiw
Copy link
Contributor Author

renfeiw commented Nov 12, 2018

This is not a mandotory, the current parsing code (written by ourselves) works without any problem so far. But it may require more effort to add any new parsing feature. To utilize the standard parser, we need to have perl XML::Parser module installed on all the machines. @AdamBrousseau Do we already have it installed?

@AdamBrousseau
Copy link
Contributor

I see XML Parser in the Adopt Unix playbooks here. So it may be on some machines. I recall an issue on this a while back. I could try and dig it up. We would have to verify all the machines have it. I assume it would be needed on any machine we compile test material on, ie. any machine we test on.

@llxia
Copy link
Contributor

llxia commented Dec 5, 2018

@AdamBrousseau Do you have any update on this? We would like to use the standard XML parser. Thanks.

@AdamBrousseau
Copy link
Contributor

I don't think it is installed on all the machines. Please open an issue at Adopt/openjdk-infrastructure to add it to the remaining playbooks.

@llxia
Copy link
Contributor

llxia commented Feb 26, 2019

Change is merged in #4785
Close this PR.

@llxia llxia closed this Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants