Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip resolver nameserver request #4988

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

sharon-wang
Copy link
Contributor

@sharon-wang sharon-wang commented Mar 5, 2019

Java programs run on z/OS are hanging when the resolver cannot contact any of the nameservers. The programs hang until the resolver times out, which is ~60 seconds. By skipping the nameserver request, this situation can be avoided.

Fixes: #4540
Documentation Issue: eclipse-openj9/openj9-docs#226

Signed-off-by: Sharon Wang sharon-wang-cpsc@outlook.com

@pshipton
Copy link
Member

pshipton commented Mar 5, 2019

You don't need to reproduce the reported delay in order to add the option.

@sharon-wang sharon-wang force-pushed the issue4540 branch 2 times, most recently from ad81512 to 89f81a0 Compare March 5, 2019 21:56
@sharon-wang sharon-wang force-pushed the issue4540 branch 2 times, most recently from f336ddf to 85c1ebb Compare March 6, 2019 15:28
@pshipton
Copy link
Member

pshipton commented Mar 6, 2019

Please create an issue at https://github.com/eclipse/openj9-docs in order to add the new options to the user guide.

@pshipton
Copy link
Member

pshipton commented Mar 6, 2019

@llxia can you please review the test changes.

@sharon-wang
Copy link
Contributor Author

sharon-wang commented Mar 6, 2019

@pshipton

Please create an issue at https://github.com/eclipse/openj9-docs in order to add the new options to the user guide.

The new options will apply to all JDK versions and all platforms?

@pshipton
Copy link
Member

pshipton commented Mar 6, 2019

The new options will apply to all JDK versions and all platforms?

Correct. Unless you are coding something to restrict either of these (or adding code to a place which is already restricted), OpenJ9 changes apply to all versions and platforms.

@pshipton
Copy link
Member

pshipton commented Mar 6, 2019

When you have the -verbose:init output, please show the section containing the new message here.

@llxia
Copy link
Contributor

llxia commented Mar 6, 2019

Could we put the test in https://github.com/eclipse/openj9/blob/master/test/functional/cmdLineTests/cmdLineTest_J9tests/j9tests.xml? In this way, we do not need to create separate build.xml and playlist.xml. And the test will run as part of cmdLineTest_J9test_extended https://github.com/eclipse/openj9/blob/b9f8b69153cc7a3c2e183c0b7ae13d819c5441f1/test/functional/cmdLineTests/cmdLineTest_J9tests/playlist.xml#L67.

@sharon-wang
Copy link
Contributor Author

Could we put the test in https://github.com/eclipse/openj9/blob/master/test/functional/cmdLineTests/cmdLineTest_J9tests/j9tests.xml? In this way, we do not need to create separate build.xml and playlist.xml. And the test will run as part of cmdLineTest_J9test_extended

openj9/test/functional/cmdLineTests/cmdLineTest_J9tests/playlist.xml

Line 67 in b9f8b69
cmdLineTest_J9test_extended
.

Sounds good, I'll move it there

@sharon-wang
Copy link
Contributor Author

@pshipton Here's the output of java -XX:-ReadIPInfoForRAS -verbose:init -version

image

Should the prefixed newline be removed and the message be indented so that it lines up with "completed with rc=0 in 34011 nano sec."?

@pshipton
Copy link
Member

pshipton commented Mar 6, 2019

Should the prefixed newline be removed and the message be indented so that it lines up with "completed with rc=0 in 34011 nano sec."?

Agreed. That would look better.

@sharon-wang sharon-wang force-pushed the issue4540 branch 3 times, most recently from 3889434 to ff8b73f Compare March 7, 2019 16:15
@sharon-wang
Copy link
Contributor Author

@pshipton Here's the updated output. Should the first letter be lowercased?
image

@pshipton
Copy link
Member

pshipton commented Mar 7, 2019

Should the first letter be lowercased?

sure, that would be consistent with the rest

@pshipton
Copy link
Member

pshipton commented Mar 7, 2019

After that, if you think this is ready to go, please remove the WIP from the title.

@sharon-wang sharon-wang changed the title WIP: Add option to skip resolver nameserver request Add option to skip resolver nameserver request Mar 7, 2019
@pshipton
Copy link
Member

pshipton commented Mar 7, 2019

jenkins test extended plinux jdk8

@pshipton
Copy link
Member

pshipton commented Mar 8, 2019

The -XX:+ReadIPInfoForRAS -XX:-ReadIPInfoForRAS test is failing because the failure condition string is a subset of the success condition string.

>> Success condition was found: [Output match: not using network query to determine host name and IP address for RAS.]
>> Failure condition was found: [Output match: using network query to determine host name and IP address for RAS.]

@pshipton
Copy link
Member

pshipton commented Mar 8, 2019

I think the failure condition could just be removed. The test will fail if the success condition is not found.

@sharon-wang
Copy link
Contributor Author

sharon-wang commented Mar 8, 2019

The -XX:+ReadIPInfoForRAS -XX:-ReadIPInfoForRAS test is failing because the failure condition string is a subset of the success condition string.

I think the failure condition could just be removed. The test will fail if the success condition is not found.

Ah yes I missed that caveat when I lowercased the first letter of each message. I'll remove the failure condition - or, I could change the messages to "enabled/disabled network query to determine host name and IP address for RAS."?

@pshipton
Copy link
Member

pshipton commented Mar 8, 2019

I could change the messages to "enabled/disabled

Sure. I don't think it makes a big difference either way, as long as the messages are understandable.

@sharon-wang
Copy link
Contributor Author

@pshipton I ended up changing the messages to include enable/disable. Just finished running the tests to confirm functionality and they passed.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes look good to me.

Java programs run on z/OS are hanging when the resolver cannot contact any of the nameservers. The programs hang until the resolver times out, which is ~60 seconds. By skipping the nameserver request, this situation can be avoided.

Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
@sharon-wang
Copy link
Contributor Author

type="fail" is not supported. "failure" was correct.

That's my bad, I missed that detail. I've changed it back to "failure".

@pshipton
Copy link
Member

pshipton commented Mar 8, 2019

jenkins test extended plinux jdk11

@pshipton pshipton merged commit 4bc1ee1 into eclipse-openj9:master Mar 9, 2019
@sharon-wang sharon-wang deleted the issue4540 branch March 12, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RESOLVER dependency
3 participants