-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to skip resolver nameserver request #4988
Conversation
You don't need to reproduce the reported delay in order to add the option. |
ad81512
to
89f81a0
Compare
test/functional/cmdLineTests/readIPInfoForRAS/readIPInfoForRAS.xml
Outdated
Show resolved
Hide resolved
f336ddf
to
85c1ebb
Compare
Please create an issue at https://github.com/eclipse/openj9-docs in order to add the new options to the user guide. |
@llxia can you please review the test changes. |
The new options will apply to all JDK versions and all platforms? |
Correct. Unless you are coding something to restrict either of these (or adding code to a place which is already restricted), OpenJ9 changes apply to all versions and platforms. |
When you have the -verbose:init output, please show the section containing the new message here. |
Could we put the test in https://github.com/eclipse/openj9/blob/master/test/functional/cmdLineTests/cmdLineTest_J9tests/j9tests.xml? In this way, we do not need to create separate build.xml and playlist.xml. And the test will run as part of |
Sounds good, I'll move it there |
@pshipton Here's the output of Should the prefixed newline be removed and the message be indented so that it lines up with "completed with rc=0 in 34011 nano sec."? |
Agreed. That would look better. |
3889434
to
ff8b73f
Compare
@pshipton Here's the updated output. Should the first letter be lowercased? |
sure, that would be consistent with the rest |
After that, if you think this is ready to go, please remove the WIP from the title. |
jenkins test extended plinux jdk8 |
The
|
I think the failure condition could just be removed. The test will fail if the success condition is not found. |
Ah yes I missed that caveat when I lowercased the first letter of each message. I'll remove the failure condition - or, I could change the messages to "enabled/disabled network query to determine host name and IP address for RAS."? |
Sure. I don't think it makes a big difference either way, as long as the messages are understandable. |
@pshipton I ended up changing the messages to include enable/disable. Just finished running the tests to confirm functionality and they passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test changes look good to me.
Java programs run on z/OS are hanging when the resolver cannot contact any of the nameservers. The programs hang until the resolver times out, which is ~60 seconds. By skipping the nameserver request, this situation can be avoided. Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
That's my bad, I missed that detail. I've changed it back to |
jenkins test extended plinux jdk11 |
Java programs run on z/OS are hanging when the resolver cannot contact any of the nameservers. The programs hang until the resolver times out, which is ~60 seconds. By skipping the nameserver request, this situation can be avoided.
Fixes: #4540
Documentation Issue: eclipse-openj9/openj9-docs#226
Signed-off-by: Sharon Wang sharon-wang-cpsc@outlook.com