Disable HPR support in prepration for removal #4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable HPR support at the option level in preparation for the codebase-wide removal of the feature. Disabling support early fixes several HPR related issues which have been propping up over the last few months since some initial refactoring was checked in which enabled fatal assertions which are now catching pre-existing HPR bugs which have been lurking in the codebase causing runtime issues. As a tactical fix, disabling HPRs will "fix" all of these problems. A subsequent PR will perform the codebase-wide cleanup which will enable us to greatly simplify and make sense of the register allocator on Z. Fixes: eclipse-openj9#4526 Fixes: eclipse-openj9#4747 Issue: eclipse-openj9#4609 Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
pshipton
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable HPR support at the option level in preparation for the
codebase-wide removal of the feature. Disabling support early fixes
several HPR related issues which have been propping up over the last
few months since some initial refactoring was checked in which enabled
fatal assertions which are now catching pre-existing HPR bugs which
have been lurking in the codebase causing runtime issues.
As a tactical fix, disabling HPRs will "fix" all of these problems. A
subsequent PR will perform the codebase-wide cleanup which will enable
us to greatly simplify and make sense of the register allocator on Z.
Fixes: #4526
Fixes: #4747
Issue: #4609
Signed-off-by: Filip Jeremic fjeremic@ca.ibm.com