Reenable disableDeferredWipeout also add deleteDirs #4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins compile plinux jdk11 |
|
jenkins compile win jdk11 |
AdamBrousseau
force-pushed
the
reenable_defered_wipeout
branch
from
ecf6dc9 to
89dba5c
Compare
- This will force the job to wait for the WS to be deleted rather than let it execute asynchronously. - Asynchronous delete often leaves the WS not completely removed in a folder called JOB_NAME_ws-cleanup_TIMESTAMP. Particularily bad on Windows. This has caused us to create a cleanup job to the remove all workspaces on all nodes. Hopefully this change will elimiate the lingering workspaces. JENKINS-54225 Related eclipse-openj9#3510 eclipse-openj9#3309 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau
force-pushed
the
reenable_defered_wipeout
branch
from
89dba5c to
c502dfe
Compare
|
@vsebe for review |
|
@llxia for merge |
llxia
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleted rather than let it execute asynchronously.
removed in a folder called JOB_NAME_ws-cleanup_TIMESTAMP.
Particularily bad on Windows. This has caused us to
create a cleanup job to the remove all workspaces on
all nodes. Hopefully this change will elimiate the
lingering workspaces.
JENKINS-54225
Related #3510 #3309
[skip ci]
Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com