Remove Java 9/10 native supports #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Feb 20, 2019
|
I think we should change all the runtime checks to #ifdef's. The build is already created specific to a Java version, I don't think there is any advantage in using runtime checks. |
Agreed, it does make sense to replace the runtime check with |
|
The only caution with #ifdefs is I want to ensure that we don't end up maintaining N-variants of the code ifdef'd differently. The costs of runtime checks helps force us to use them sparingly and therefore make as little code version specific as possible. |
Replaced J2SE_19 with J2SE_V11; Removed redundant J2SE_VERSION(vm) & with J2SE_RELEASE_MASK or J2SE_VERSION_MASK. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
|
jenkins test sanity win jdk8,jdk11 |
pshipton
approved these changes
Feb 21, 2019
This was referenced Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Java 9/10native supportsReplaced
J2SE_19withJ2SE_V11;Removed redundant
J2SE_VERSION(vm) &withJ2SE_RELEASE_MASKorJ2SE_VERSION_MASK.Reviewer: @DanHeidinga
Signed-off-by: Jason Feng fengj@ca.ibm.com