Add Power-specific relocation types needed for SVM AOT #4781

aviansie-ben · 2019-02-19T18:14:04Z

For the Power codegen to work correctly with the newly implemented
Symbol Validation Manager for AOT, a couple new relocation types need to
be added:

TR_DiscontiguousSymbolFromManager represents a discontiguous load
sequence that needs to be relocated with a symbol from the SVM
TR_ResolvedTrampolines represents the need to reserve a trampoline
for a resolved method

Signed-off-by: Ben Thomas ben@benthomas.ca

runtime/compiler/codegen/J9AheadOfTimeCompile.cpp

runtime/compiler/runtime/RelocationRecord.cpp

dsouzai · 2019-02-19T22:55:41Z

runtime/compiler/runtime/RelocationRecord.cpp

@@ -3911,12 +3918,12 @@ TR_RelocationRecordSymbolFromManager::applyRelocation(TR_RelocationRuntime *relo
   if (reloRuntime->reloLogger()->logEnabled())
      {
      reloRuntime->reloLogger()->printf("%s\n", name());
-      reloRuntime->reloLogger()->printf("\tpreparePrivateData: symbol %p\n", symbol);
+      reloRuntime->reloLogger()->printf("\tapplyRelocation: symbol %p\n", symbol);


dsouzai

You should also add the sizes of the binary templates to TR_RelocationRecord::_relocationRecordHeaderSizeTable since that will be the canonical table of relo header sizes once all the AOT consolidation work is done.

runtime/compiler/p/codegen/J9AheadOfTimeCompile.cpp

runtime/compiler/runtime/RelocationRecord.hpp

For the Power codegen to work correctly with the newly implemented Symbol Validation Manager for AOT, a couple new relocation types need to be added: 1. TR_DiscontiguousSymbolFromManager represents a discontiguous load sequence that needs to be relocated with a symbol from the SVM 2. TR_ResolvedTrampolines represents the need to reserve a trampoline for a resolved method Signed-off-by: Ben Thomas <ben@benthomas.ca>

aviansie-ben · 2019-02-20T14:55:58Z

@dsouzai All the issues you brought up should be fixed now

dsouzai · 2019-02-20T15:48:18Z

jenkins test sanity xlinux,zlinux,plinux,aix jdk8,jdk11

dsouzai · 2019-02-20T16:15:38Z

jenkins test sanity zlinux jdk8

dsouzai · 2019-02-20T21:39:52Z

15:14:17 TOTAL: 192   EXECUTED: 114   PASSED: 114   FAILED: 0   SKIPPED: 78
15:14:17 ALL TESTS PASSED

All tests passed; I guess the "build failed" is because of a Jenkins hiccup.

aviansie-ben mentioned this pull request Feb 19, 2019

All JIT Power work for "Improvements for Relocatable Compilations #2921" #4242

Closed

dsouzai added comp:jit comp:jit:p comp:jit:aot labels Feb 19, 2019

dsouzai self-assigned this Feb 19, 2019