Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase JVM_INTERFACE_VERSION to 6 for JDK11+ #4773

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

JasonFengJ9
Copy link
Member

@JasonFengJ9 JasonFengJ9 commented Feb 18, 2019

Increase JVM_INTERFACE_VERSION to 6 for JDK11+

This is required by JCL extension changes. In addition, minor refactoring to make Trc_SC_GetInterfaceVersion_Entry first call.
Note: changed J2SE_19 to J2SE_V11 since Java 9/10 is out of service.

Manually verified that JDK11 builds with this PR.

openjdk version "11.0.2-internal" 2019-01-15
OpenJDK Runtime Environment (build 11.0.2-internal+0-adhoc.jason.openj9-openjdk-jdk11)
Eclipse OpenJ9 VM (build master-7d048d4, JRE 11 Linux amd64-64-Bit Compressed References 20190219_000000 (JIT enabled, AOT enabled)
OpenJ9   - 7d048d4
OMR      - 6e7568d
JCL      - 455c2c3 based on jdk-11.0.2+9)

related: #4770

Reviewer: @DanHeidinga

Signed-off-by: Jason Feng fengj@ca.ibm.com

This is required by extension changes.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Note, this is a first (?) step towards removing support for 9 / 10 from the code base as with this change, 9 is no longer viable.

@DanHeidinga
Copy link
Member

Jenkins test sanity zlinux jdk11

@DanHeidinga DanHeidinga self-assigned this Feb 19, 2019
@JasonFengJ9
Copy link
Member Author

Note, this is a first (?) step towards removing support for 9 / 10 from the code base as with this change, 9 is no longer viable.

Yes, this is first step to remove support for Java 9/10 support. Am going to open another PR to make similar changes.

@keithc-ca
Copy link
Contributor

With the mergers of the JVMs and JCLs, Java 9 and 10 won't build without additional changes.

@DanHeidinga
Copy link
Member

updated the comment so this won't close #4770 as there may be additional things needed for the interface version

@DanHeidinga DanHeidinga merged commit 3d13f4d into eclipse-openj9:master Feb 19, 2019
@JasonFengJ9 JasonFengJ9 deleted the jvmif6 branch April 4, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants