Exclude tests for JDK12+ #4753
Merged
Exclude tests for JDK12+ #4753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, missed [skip ci]. |
|
jenkins test sanity plinux jdk11 |
smlambert
reviewed
Feb 15, 2019
| @@ -46,7 +46,7 @@ | |||
| <group>functional</group> | |||
| </groups> | |||
| <subsets> | |||
| <subset>9+</subset> | |||
| <subset>9|10|11</subset> | |||
There was a problem hiding this comment.
Does '|' delimited actually work (get parsed properly by TKG)? As 9/10 are now retired, I guess you could also just use 11 here if not.
There was a problem hiding this comment.
Thanks @smlambert , from a local test, make -f run_configure.mk and make compile finished successfully and make _TestFlushReflectionCache_0 didn't run the test in question (was able to reproduce the failure java.lang.NoSuchFieldException: annotations.
Will remove 9/10 then.
There was a problem hiding this comment.
@smlambert PR has been updated, please review again.
Excluding following tests: TestFlushReflectionCache - NoSuchFieldException: annotations; cmdLineTester_jvmtitests_hcr_ - NoSuchFieldException: methodAccessor; TestRefreshGCSpecialClassesCache_BCI_FAST_HCR - UnsupportedOperationException: This feature requires ASM7; TestGCClassWithStaticRetransformInBalanced - UnsupportedOperationException: This feature requires ASM5. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
JasonFengJ9
force-pushed
the
excludejdk12failures
branch
from
b5c8117 to
3e6610f
Compare
smlambert
approved these changes
Feb 15, 2019
pshipton
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude tests for
JDK12+Excluding following tests:
Related to: #4658, #4662, #4663
Reviewer: @llxia
FYI: @pshipton
Signed-off-by: Jason Feng fengj@ca.ibm.com