Collapse JCL shared libraries into a single version #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use StandardCharsets.UTF_8 to avoid IOException * use a single StringBuilder in hex() * use a single StringBuilder in JCLRuntimeFlag.cDefine() * use a TreeMap to manage flag order * improve error message for missing option values * remove redundant casts * fix incorrect javadoc Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
* remove version-specific JCLs & sunvmi_jdk11 Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
* fix J9_DLL_NAME * inline JCL validation * remove references to 'jclscar' * use VMOPT_XJCL_COLON instead of redundant OPT_XJCL_COLON Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
This was referenced Feb 14, 2019
keithc-ca
changed the title
|
The travis failure is expected because it didn't build with ibmruntimes/openj9-openjdk-jdk11#137. |
|
jenkins test sanity zlinux,win jdk8,jdk11 |
|
jenkins test sanity zlinux,win jdk8 depends ibmruntimes/openj9-openjdk-jdk8#272 |
|
jenkins test sanity zlinux,win jdk11 depends ibmruntimes/openj9-openjdk-jdk11#137 |
keithc-ca
changed the title
pshipton
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will dramatically simplify working with multiple Java versions from the single openj9 code base.
Instead of trying to manage multiple JCL shared libraries and the complexities of adding a new version every six months, additions and removals can be conditional in C/C++ code based on
JAVA_SPEC_VERSIONor included in the constant pool for specific versions via theversions="..."attribute invmconstantpool.xml.This PR:
Must be merged together with:
See also: #4632.