Modify metronome Scheduler for moving into OMR #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-hall
force-pushed
the
metronome8
branch
5 times, most recently
from
598cbeb to
d084bd0
Compare
|
Jenkins test sanity xLinux jdk8 |
|
Jenkins test sanity AIX jdk11 |
|
Jenkins compile win |
|
@charliegracie Would you please provide instructions how hook data should be modified instead of be moved to delegate? |
jason-hall
force-pushed
the
metronome8
branch
4 times, most recently
from
de3fb0c to
218a8de
Compare
|
This should be ready for review |
runtime/gc_realtime/Scheduler.cpp
Outdated
| #include "j9protos.h" | ||
| #include "j9consts.h" | ||
| #include "modronopt.h" | ||
| #include "ModronAssertions.h" |
There was a problem hiding this comment.
I would not remove this include, code in this file contains MM Assertions
|
Jenkins compile win |
|
Jenkins test sanity xLinux jdk8 |
Signed-off-by: Jason Hall <jasonhal@ca.ibm.com>
|
While we're looking at those class forward declarations in Scheduler.hpp, I don't think "class ILogger" even exists and forward declaring "class Scheduler" before class Scheduler seems pointless. |
dmitripivkine
approved these changes
Mar 19, 2019
|
Jenkins compile win |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Hall jasonhal@ca.ibm.com