Ensure return code checked first in MXBean code #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values in Eclipse OMR for the unlimited and unknown are the same: ``` ``` https://github.com/eclipse/omr/blob/cf3e1b622090ddb922717aa1b8c616ffa11c80a7/include_core/omrport.h#L161-L162 We need to differentiate between them based on the return value of the `j9sysinfo_get_limit` call - it will return `OMRPORT_LIMIT_UNKNOWN` in the unknown case. Also fixed the tabs vs spaces issues in surrounding code. Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
DanHeidinga
force-pushed
the
djh/returncheck
branch
from
81c76ca to
ee07737
Compare
|
jenkins test sanity xlinux jdk8 |
|
jenkins test sanity plinux jdk8 |
pshipton
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values in Eclipse OMR for the unlimited and unknown are the same:
https://github.com/eclipse/omr/blob/cf3e1b622090ddb922717aa1b8c616ffa11c80a7/include_core/omrport.h#L161-L162
We need to differentiate between them based on the return value
of the
j9sysinfo_get_limitcall - it will returnOMRPORT_LIMIT_UNKNOWNin the unknown case.Also fixed the tabs vs spaces issues in surrounding code.
Signed-off-by: Dan Heidinga daniel_heidinga@ca.ibm.com