Commonize definitions of jint & jbyte #4680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The copyright check failed. |
Removed ifdefs for unsupported platforms and cleaned up duplicate definitions. Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
|
Thanks - copyright check is fixed now. |
gacholio
approved these changes
Feb 11, 2019
|
jenkins compile win,zlinux jdk8 |
DanHeidinga
added a commit
to DanHeidinga/openj9
that referenced
this pull request
Apr 30, 2019
The previous PR `Commonize definitions of jint & jbyte` eclipse-openj9#4680 cleaned up too many defines. Not having this resulted in missing exports on natives compiled on windows. Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
DanHeidinga
added a commit
to DanHeidinga/openj9
that referenced
this pull request
May 9, 2019
The previous PR `Commonize definitions of jint & jbyte` eclipse-openj9#4680 cleaned up too many defines. Not having this resulted in missing exports on natives compiled on windows. Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed ifdefs for unsupported platforms and cleaned up duplicate
definitions.
Signed-off-by: Dan Heidinga daniel_heidinga@ca.ibm.com