Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert TR_J9SharedCache APIs in Optimizer to fej9 APIs #4668

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

harryyu1994
Copy link
Contributor

@harryyu1994 harryyu1994 commented Feb 8, 2019

The purpose of this change is to hide away the TR_J9SharedCache APIs that are called in the Optimizer so that the Optimizer doesn't need to know about the TR_J9SharedCache object. The Optimizer can query information about the TR_J9SharedCache object through J9 frontend APIs.

Signed-off-by: Harry Yu harryyu1994@gmail.com

@harryyu1994 harryyu1994 changed the title WIP: Convert TR_J9SharedCache APIs in Optimizer to fej9 APIs Convert TR_J9SharedCache APIs in Optimizer to fej9 APIs Feb 8, 2019
@harryyu1994
Copy link
Contributor Author

@dsouzai Hi Irwin, I'm wondering if you could review this?

Copy link
Contributor

@dsouzai dsouzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the #include "env/SharedCache.hpp" in both InlinerTempForJ9.cpp and J9Inliner.cpp.

@harryyu1994
Copy link
Contributor Author

change updated.

@dsouzai
Copy link
Contributor

dsouzai commented Feb 11, 2019

You'll have to fix the copyrights; I'll hold off kicking off the jenkins tests until then.

The purpose of this change is to hide away the TR_J9SharedCache APIs that were called in the Optimizer so that the Optimizer doesn't need to know about the TR_J9SharedCache object. The Optimizer can query about the TR_J9SharedCache object through J9 frontend APIs.

Signed-off-by: Harry Yu <harryyu1994@gmail.com>
@harryyu1994
Copy link
Contributor Author

copyright fixed.

@dsouzai
Copy link
Contributor

dsouzai commented Feb 11, 2019

jenkins test sanity all jdk11

@dsouzai
Copy link
Contributor

dsouzai commented Feb 11, 2019

Staging OpenJ9 sourcetools in /home/jenkins/jenkins-agent/workspace/PullRequest-Sanity-JDK11-linux_390-64_cmprssptrs-OpenJ9/build/linux-s390x-normal-server-release/vm
Overriding jvm.cfg with J9VM version
/bin/ln: failed to create symbolic link '/home/jenkins/jenkins-agent/workspace/PullRequest-Sanity-JDK11-linux_390-64_cmprssptrs-OpenJ9/build/linux-s390x-normal-server-release/jdk/lib/jvm.cfg': File exists
ModuleWrapper.gmk:72: recipe for target '/home/jenkins/jenkins-agent/workspace/PullRequest-Sanity-JDK11-linux_390-64_cmprssptrs-OpenJ9/build/linux-s390x-normal-server-release/jdk/lib/jvm.cfg' failed
make[3]: *** [/home/jenkins/jenkins-agent/workspace/PullRequest-Sanity-JDK11-linux_390-64_cmprssptrs-OpenJ9/build/linux-s390x-normal-server-release/jdk/lib/jvm.cfg] Error 1
make[3]: *** Deleting file '/home/jenkins/jenkins-agent/workspace/PullRequest-Sanity-JDK11-linux_390-64_cmprssptrs-OpenJ9/build/linux-s390x-normal-server-release/jdk/lib/jvm.cfg'
make[3]: *** Waiting for unfinished jobs....
make/Main.gmk:162: recipe for target 'java.base-copy' failed
make[2]: *** [java.base-copy] Error 1

🤷‍♂️

@dsouzai
Copy link
Contributor

dsouzai commented Feb 11, 2019

jenkins test sanity zlinux jdk11

@dsouzai dsouzai merged commit 4e82d75 into eclipse-openj9:master Feb 11, 2019
@harryyu1994 harryyu1994 deleted the sharedCache branch February 13, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants