Add test utility methods to get attach API information

[pdbain-ibm]

Add methods to check for attach API initialization, get process ID, and get
virtual machine ID.

Use reflection to avoid compile-time dependency on OpenJ9 internal classes by tests.
Replace some existing references to AttachHandler in favour of the new methods.

This is further to "Use reflection to access attach API internal APIs" #2962. This allows tests to remove references to attach API implementation classes and compile without requiring --add-exports java.base/com.ibm.tools.attach.target.

This is cleanup in preparation for tests of new features in #4655.

Signed-off-by: Peter Bain peter_bain@ca.ibm.com

[pdbain-ibm]

This is cleanup in preparation for anticipated new attach API tests arising from #2543.

[pshipton]

@pdbain-ibm the description doesn't seem to match the code. I thought this was going to be vm changes but it is all test changes. Is the change as intended?

Also, I think we need an Issue that each PR can refer to, so all the attach and utility changes can be tied together.

[pdbain-ibm]

@pshipton This is cleaning up some very old Attach API test code that relied on access to implementation classes and made compilation difficult.

There is no issue at present, though I expect to use these utilities for testing #2377,
#4650, et al. Possibly @llxia should review this?

[pshipton]

Please fix the commit title as well.

[pshipton]

The Issue I'm thinking of is for jps, jstack, etc. There should be a high level issue and every related PR should refer to it.

[llxia]

jenkins test all xlinux jdk8,jdk11

[llxia]

jenkins test all xlinux jdk11

[llxia]

jenkins test sanity xlinux jdk11

[llxia]

jenkins test extended xlinux jdk11

[pshipton]

@pdbain-ibm while the changes themselves look fine, com.ibm.tools.attach.target.AttachHandler is still hard coded. I assume you are planning additional changes later that will cause this change to make sense?

[pdbain-ibm]

@pshipton This is further to "Use reflection to access attach API internal APIs" #2962. This allows tests to remove references to attach API implementation classes and compile without requiring --add-exports java.base/com.ibm.tools.attach.target.

[pshipton]

It would be clearer if that information was in the commit comment and description of this PR.

[pdbain-ibm]

It would be clearer if that information was in the commit comment and description of this PR.

Done.

[pshipton]

@smlambert lgtm

[smlambert]

https://ci.eclipse.org/openj9/view/Test/job/Test-Grinder/267
https://ci.eclipse.org/openj9/view/Test/job/Test-Grinder/268

[smlambert]

I have merged this, however, jdk8/jdk11 grinders 276/278 eventually failed, am assuming missing native test libs, as I did not upload them to the job:

org.openj9.test.attachAPI.TestAttachAPI.test_agntld02
org.openj9.test.attachAPI.TestAttachAPI.test_agntld01
org.openj9.test.attachAPI.TestAttachAPI.test_agntld03

[AttachApiTest] [ERROR] com.sun.tools.attach.AgentLoadException: ATTACH_ERR AgentLoadException jvmtitest:
at com.ibm.tools.attach.attacher.OpenJ9VirtualMachine.parseResponse(OpenJ9VirtualMachine.java:326)
at com.ibm.tools.attach.attacher.OpenJ9VirtualMachine.loadAgentLibrary(OpenJ9VirtualMachine.java:244)