Clean up deprecated code resulting from migrating to a unified assembler across x86 #4627
Conversation
nbhuiyan
force-pushed
the
masm-cleanup
branch
from
0356f31 to
47d18d8
Compare
.asm and .inc x86 assembly files are no longer used on Windows, and the masm2gas script is no longer used to generate GNU assembly from MASM to be consumed on Linux. NASM is now used throughout x86 OSes instead. Signed-off-by: Nazim Uddin Bhuiyan <nazimudd@ualberta.ca>
We no longer need to distinguish them from .inc files in MASM format. All the .inc assembly files are in NASM format. Signed-off-by: Nazim Uddin Bhuiyan <nazimudd@ualberta.ca>
* Removed .asm file list from the x86 Makefiles as they are no longer used. * Removed makefile rules to handle .asm and .pasm files across x86 * Disabled setting up of masm2gas script on xLinux in the makefiles * No longer defining NASM_ASSEMBLER macro in asmprotos.h to declare NASM-compatible helpers while maintaining support for using MASM/GAS, and instead guarding code with x86 platform checks where necessary. Signed-off-by: Nazim Uddin Bhuiyan <nazimudd@ualberta.ca>
nbhuiyan
force-pushed
the
masm-cleanup
branch
from
47d18d8 to
4994457
Compare
|
@0xdaryl ready for review |
|
Jenkins test sanity win,xlinux,xlinuxlargeheap jdk11 |
|
Jenkins test sanity win32 jdk8 |
|
Changes look reasonable to me. One unfortunate consequence is that we lose the history on the deleted assembly files without doing a bit of git work to dig it out. However, this probably isn't such a big deal in practice because there isn't much of a history on these assembly files in the 1.5 years this code has been open sourced. @0dvictor , I'd appreciate a +1 from you too. |
|
Changes look good to me. I totally agree deleting these deprecated files; they are slowly out-of-sync and likely stop work in the future. Despite the short history of these files, all histories are still in git though it takes more effort retrieving it. I don't anticipate frequent need of these histories. |
|
Jenkins test sanity plinux,zlinux jdk11 |
This PR removes the MASM assembly files and cleans up the dual (or triple, if you want to count masm2gas) assembler solutions that existed during the transition period.
Closes: #3148