Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code for obsolete Java 9 'shapes' #4626

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Remove dead code for obsolete Java 9 'shapes' #4626

merged 1 commit into from
Feb 6, 2019

Conversation

keithc-ca
Copy link
Contributor

  • remove J2SE_SHAPE_B136, J2SE_SHAPE_B148
  • replace J2SE_SHAPE_B165 with J2SE_SHAPE_V9

@keithc-ca
Copy link
Contributor Author

FYI @JasonFengJ9

JasonFengJ9
JasonFengJ9 reviewed Feb 6, 2019
View reviewed changes
@keithc-ca
Remove dead code for obsolete Java 9 'shapes'
c4ff462 
* remove J2SE_SHAPE_B136, J2SE_SHAPE_B148
* replace J2SE_SHAPE_B165 with J2SE_SHAPE_V9

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
JasonFengJ9
JasonFengJ9 approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@JasonFengJ9 JasonFengJ9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming moduleClass is moved even closer to its usage)

@pshipton
Copy link
Member

pshipton commented Feb 6, 2019 •
edited
Loading

jenkins test sanity zlinux jdk8,jdk11
https://ci.eclipse.org/openj9/job/PullRequest-Sanity-JDK8-linux_390-64_cmprssptrs-OpenJ9/579/
https://ci.eclipse.org/openj9/job/PullRequest-Sanity-JDK11-linux_390-64_cmprssptrs-OpenJ9/188/

@pshipton pshipton merged commit 49370cc into eclipse-openj9:master Feb 6, 2019
@keithc-ca keithc-ca deleted the shapes branch February 6, 2019 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonFengJ9 JasonFengJ9 JasonFengJ9 approved these changes

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keithc-ca @pshipton @JasonFengJ9 @fjeremic