Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read of FPC register #4477

Merged
merged 1 commit into from
Jan 28, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions runtime/compiler/runtime/SignalHandler.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2018 IBM Corp. and others
* Copyright (c) 2000, 2019 IBM Corp. and others
*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -920,7 +920,6 @@ UDATA jit390Handler(J9VMThread* vmThread, U_32 sigType, void* sigInfo)
const char* infoName;
UDATA *controlPC;
UDATA controlPCValue;
UDATA *controlFPC;
UDATA *entryPointRegister;
U_8 DXC;
U_8 ILC;
Expand All @@ -941,13 +940,12 @@ UDATA jit390Handler(J9VMThread* vmThread, U_32 sigType, void* sigInfo)
controlPCValue = *controlPC;

infoType = j9sig_info(sigInfo, J9PORT_SIG_CONTROL, J9PORT_SIG_CONTROL_S390_FPC, &infoName, &infoValue);
if (infoType != J9PORT_SIG_VALUE_ADDRESS)
if (infoType != J9PORT_SIG_VALUE_32)
return J9PORT_SIG_EXCEPTION_CONTINUE_SEARCH;

controlFPC = (UDATA *) infoValue;
DXC = *(U_8 *)(((U_8 *)controlFPC)+2);
DXC = *(U_8 *)(((U_8 *)infoValue) + 2);

if (J9PORT_SIG_FLAG_SIGFPE == sigType && DXC == (U_8)0xFF)
if (J9PORT_SIG_FLAG_SIGFPE == sigType && DXC == (U_8)0xFF)
{
trapType = jit390IdentifyCodeCacheTrapType(vmThread, (U_8 *) controlPCValue, &ILC, sigInfo);
controlPCValue = controlPCValue - ILC;
Expand Down