Provide method name when constructing VarHandleInvokeHandle #4458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pdbain-ibm Can you fix the copyright date? |
|
Can you also add MethodHandleInfo tests for all the VarHandle APIs? Something similar to https://github.com/eclipse/openj9/blob/2f295ea91cdd97ff37eb5d164fc63014ea718bc7/test/functional/Java8andUp/src/org/openj9/test/java/lang/invoke/Test_MethodHandleInfo.java but applicable to Java 11+. That can be done in a separate PR |
Fixes eclipse-openj9#3180 Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
pdbain-ibm
force-pushed
the
methodhandle
branch
from
8b234bb to
8590ac9
Compare
|
Copyright fixed, issue for test case #4459. |
|
Jenkins test sanity zlinux jdk11 |
pdbain-ibm
added a commit
to pdbain-ibm/openj9
that referenced
this pull request
Apr 2, 2019
Test for eclipse-openj9#3180 This depends on eclipse-openj9#4458 [ci skip] Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3180
Signed-off-by: Peter Bain peter_bain@ca.ibm.com