Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update omrsysinfo_is_running_in_container() signature #4411

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

DanHeidinga
Copy link
Member

OMR updated omrsysinfo_is_running_in_container() to remove the
errorCode parameter in eclipse-omr/omr#3420

This change helps the openj9-omr to promote

Signed-off-by: Dan Heidinga daniel_heidinga@ca.ibm.com

@pshipton
Copy link
Member

pshipton commented Jan 23, 2019

The copyright check failed.

We also have #4183, although that one is marked WIP, and also has a copyright check failure.

@pshipton pshipton added comp:vm depends:omr Pull request is dependent on a corresponding change in OMR labels Jan 23, 2019
OMR updated omrsysinfo_is_running_in_container() to remove the
`errorCode` parameter in eclipse-omr/omr#3420

This change helps the openj9-omr to promote

Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
@pshipton pshipton merged commit 8e36ae2 into eclipse-openj9:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants