Set inlined index on BCDCHK node for AOT relocation #4386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set inlined site index to make sure AOT TR_RelocationRecordConstantPool::computeNewConstantPool() API can correctly compute a new CP to relocate DAA OOL calls. Given that the CP addresses are now correct, enable DAA in AOT mode. Signed-off-by: Nigel Yu <yunigel@ca.ibm.com>
|
This pull request reverts #4354 and fixes DAA so that outlined function calls snippets has the correct relocated constant pool address for VM helpers. |
|
@fjeremic FYI |
fjeremic
approved these changes
Jan 22, 2019
|
Jenkins test sanity zlinux JDK8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set inlined site index to make sure AOT
TR_RelocationRecordConstantPool::computeNewConstantPool() API can
correctly compute a new CP to relocate DAA OOL calls.
Given that the CP addresses are now correct, enable DAA in AOT mode.
Fixes: #4363
Signed-off-by: Nigel Yu yunigel@ca.ibm.com