Anchor arguments of MethodHandle invoke before expansion #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewcraik Can I have you review? |
|
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
The expansion will insert calls before the original call. Anchor the arguments such that the evaluation of arguments is before the execution of the call. Notice that missing the anchoring does not cause functional issues because the inserted calls are internal to the JIT and have no side effect on arguments. However, it prevents us from folding argument that is a static final field because the inserted calls are unsupported potential OSR points. Signed-off-by: Liqun Liu <liqunl@ca.ibm.com>
|
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
1 similar comment
|
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
|
error looks to be a repeat of existing javac issue and unrelated to change - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expansion will insert calls before the original call. Anchor the
arguments such that the evaluation of arguments is before the execution
of the call.
Notice that missing the anchoring does not cause functional issues
because the inserted calls are internal to the JIT and have no side
effect on arguments. However, it prevents us from folding argument that
is a static final field because the inserted calls are unsupported
potential OSR points.
Signed-off-by: Liqun Liu liqunl@ca.ibm.com