Update playlist for the access check on module #4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewer: @DanHeidinga |
|
The change is to fix the test failure triggered by the changes at ibmruntimes/openj9-openjdk-jdk11#93 |
The minor change is to export the requested Oracle class to unnamed modules. Fix: eclipse-openj9#4313 Signed-off-by: CHENGJin <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
test_config_update_module_access
branch
from
d9bf519 to
2ab6104
Compare
|
jenkins test sanity zlinux jdk11 |
|
@ChengJin01 can we close #4313 with this fix? |
|
@pshipton, technically there should no problem with fix. Or we can wait till @andrew-m-leonard confirms that with his build. |
|
I just wanted to confirm adding "close #4313" to the description, in order to auto-close the Issue when the PR is merged. |
pshipton
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minor change is to export the requested
Oracle class to unnamed modules.
Close #4313
Signed-off-by: CHENGJin jincheng@ca.ibm.com