Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use strip '-r' option to retain external symbols" #4284

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Revert "Use strip '-r' option to retain external symbols" #4284

merged 1 commit into from
Jan 14, 2019

Conversation

pshipton
Copy link
Member

Reverts #4276

It seems not to be working as desired. Internal jdk8 testing is showing consistent failures in 64-bit (both compressedrefs and not) cmdLineTester_callsitedbgddrext DDR testing.

Testing: Run !printallcallsites
...
>> Success condition was not found: [Output match: jvminit.c]

Testing: Run !findallcallsites
...
 [OUT] > Unexpected CDE reading contents of 10010012630
 [OUT] com.ibm.j9ddr.corereaders.memory.MemoryFault: Memory Fault reading 0x90000000D9F7C2C : MemoryFault loading cache block, unbacked memory

@pshipton pshipton merged commit 6f70898 into master Jan 14, 2019
@keithc-ca keithc-ca deleted the revert-4276-strip-r branch January 14, 2019 15:59
@LinHu2016 LinHu2016 mentioned this pull request Sep 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pshipton