Use a set in SymbolValidationManager::recordExists #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
dsouzai
reviewed
Jan 11, 2019
| LexicalOrder() : _result(EQUAL) { } | ||
| LexicalOrder(const LexicalOrder &other) : _result(other._result) { } | ||
|
|
||
| static LexicalOrder by(void *a, void *b) { return LexicalOrder().thenBy(a, b); } |
There was a problem hiding this comment.
Should the return type be LexicalOrder & (because of LexicalOrder &thenBy(void *a, void *b))?
There was a problem hiding this comment.
There's no LexicalOrder we could reference here that lives past the return, edit: so this returns a copy
There was a problem hiding this comment.
I see; then I guess my question is, why have thenBy return a reference when passed in void * but return by value when passed in uintptr_t ?
There was a problem hiding this comment.
Oh, thanks - I didn't mean to copy in thenBy(uintptr_t, uintptr_t)
The symbol validation manager uses a linear search along with an equality comparison in order to detect and filter out duplicate records. This commit replaces the equality comparison with an ordering comparison in order to allow the linear scan to be replaced by a set lookup. Signed-off-by: Devin Papineau <devinmp@ca.ibm.com>
This reduces the running time of recordExists from linear to log time. Furthermore, by using a separate data structure here, it's now possible to seed the set with records that should not be generated. Signed-off-by: Devin Papineau <devinmp@ca.ibm.com>
jdmpapin
force-pushed
the
svm.record-set
branch
from
e73bba2 to
d46377b
Compare
dsouzai
approved these changes
Jan 11, 2019
|
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
1 similar comment
|
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
|
Jenkins copyright check |
|
Jenkins line endings check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the running time of
recordExistsfrom linear to log time. Furthermore, by using a separate data structure here, it's now possible to seed the set with records that should not be generated.An ordering comparison is defined on validation records in order to allow them to be kept in a set.