Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new jit hook jitFlushCompilationQueue #4252

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

cathyzhyi
Copy link
Contributor

This new hook is needed to differenciate the case of extended HCR and
data break point. The same API jitClassesRedefined was used for both
cases before but they require different action now. Separate the code
to flush jit compilation queue into this new API which can be used for
data break point.

see Issue: #3590

Signed-off-by: Yi Zhang yizhang@ca.ibm.com

@andrewcraik
Copy link
Contributor

seems reasonable to me - any concerns @mpirvu ?

@andrewcraik
Copy link
Contributor

Jenkins test sanity xlinux,win,plinux jdk8,jdk11

@andrewcraik
Copy link
Contributor

Jenkins test sanity xlinux,win,plinux jdk8,jdk11

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cathyzhyi
Copy link
Contributor Author

the Copyright Check and Line Endings Check do not really check failures.

@gacholio
Copy link
Contributor

If you make the last change I suggested, the failed jobs will be restarted.

@andrewcraik
Copy link
Contributor

@cathyzhyi can you reply to @gacholio's last comment and either make the update or force push so we can get this thing relaunched?

This new hook is needed to differenciate the case of extended HCR and
data break point. The same API jitClassesRedefined was used for both
cases before but they require different action now. Separate the code
to flush jit compilation queue into this new API which can be used for
data break point.

Signed-off-by: Yi Zhang <yizhang@ca.ibm.com>
@cathyzhyi
Copy link
Contributor Author

@andrewcraik Thanks for the reminder. Addressed GAC's comment.

@andrewcraik
Copy link
Contributor

Jenkins test sanity xlinux,win,plinux jdk8,jdk11

Copy link
Contributor

@andrewcraik andrewcraik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewcraik andrewcraik merged commit bd4691c into eclipse-openj9:master Jan 14, 2019
@cathyzhyi
Copy link
Contributor Author

matching VM change #4294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants