-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new jit hook jitFlushCompilationQueue #4252
Conversation
seems reasonable to me - any concerns @mpirvu ? |
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the |
If you make the last change I suggested, the failed jobs will be restarted. |
@cathyzhyi can you reply to @gacholio's last comment and either make the update or force push so we can get this thing relaunched? |
This new hook is needed to differenciate the case of extended HCR and data break point. The same API jitClassesRedefined was used for both cases before but they require different action now. Separate the code to flush jit compilation queue into this new API which can be used for data break point. Signed-off-by: Yi Zhang <yizhang@ca.ibm.com>
@andrewcraik Thanks for the reminder. Addressed GAC's comment. |
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
matching VM change #4294 |
This new hook is needed to differenciate the case of extended HCR and
data break point. The same API jitClassesRedefined was used for both
cases before but they require different action now. Separate the code
to flush jit compilation queue into this new API which can be used for
data break point.
see Issue: #3590
Signed-off-by: Yi Zhang yizhang@ca.ibm.com