Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow dollars in identifiers #4219

Merged
merged 1 commit into from
Feb 12, 2019
Merged

allow dollars in identifiers #4219

merged 1 commit into from
Feb 12, 2019

Conversation

rwy7
Copy link
Contributor

@rwy7 rwy7 commented Jan 9, 2019 •
edited
Loading

Apple patches libstdc++v3 with additional support for dtrace. These dtrace
symbols use dollar signs identifiers, and are incompatible with the
compile option -fno-dollars-in-identifiers. This commit removes the
option.

Signed-off-by: Robert Young rwy0717@gmail.com

@rwy7 rwy7 changed the title WIP: compiler: build: allow dollars in identifiers compiler: build: allow dollars in identifiers Jan 9, 2019
@rwy7
Allow dollars in identifiers
629dc64 
Apple patch libstdc++v3 with additional support for dtrace. These dtrace
symbols use dollar signs indentifiers, and are incompatible with the
compile option -fno-dollars-in-identifiers. This commit removes the
option.

Signed-off-by: Robert Young <rwy0717@gmail.com>
@rwy7
Copy link
Contributor Author

rwy7 commented Jan 9, 2019

Got some details wrong, it's not libc++, it's Apple's modified libstdc++ that uses dollar signs.

Here's a patch that shows the difference:
https://github.com/mattl/opensource.apple.com/blob/master/src/DeveloperTools-10A394/10A394/libstdcxx-39/patches-4.2.1/dtrace.patch

@rwy7
Copy link
Contributor Author

rwy7 commented Feb 11, 2019

/cc @0xdaryl

@0xdaryl
Copy link
Contributor

0xdaryl commented Feb 11, 2019

Jenkins test sanity all jdk11

@0xdaryl
Copy link
Contributor

0xdaryl commented Feb 11, 2019

@jjohnst-us, can you confirm this won't cause a problem for zTPF?

@jjohnst-us
Copy link
Contributor

@0xdaryl
Shouldn't be an issue, today our systems don't compile with that flag. The change should impact us in the same was the other GCC platforms. I spotted one or two segments in our system which has a $ in an identifier, so presumably it should be okay.

@rwy7
Copy link
Contributor Author

rwy7 commented Feb 12, 2019

To me, the CI failure looks unrelated:

Staging OpenJ9 sourcetools in /home/jenkins/workspace/PullRequest-Sanity-JDK11-linux_x86-64-OpenJ9/build/linux-x86_64-normal-server-release/vm
Overriding jvm.cfg with J9VM version
/bin/ln: failed to create symbolic link '/home/jenkins/workspace/PullRequest-Sanity-JDK11-linux_x86-64-OpenJ9/build/linux-x86_64-normal-server-release/jdk/lib/jvm.cfg': File exists
ModuleWrapper.gmk:72: recipe for target '/home/jenkins/workspace/PullRequest-Sanity-JDK11-linux_x86-64-OpenJ9/build/linux-x86_64-normal-server-release/jdk/lib/jvm.cfg' failed
gmake[3]: *** [/home/jenkins/workspace/PullRequest-Sanity-JDK11-linux_x86-64-OpenJ9/build/linux-x86_64-normal-server-release/jdk/lib/jvm.cfg] Error 1
gmake[3]: *** Deleting file '/home/jenkins/workspace/PullRequest-Sanity-JDK11-linux_x86-64-OpenJ9/build/linux-x86_64-normal-server-release/jdk/lib/jvm.cfg'
gmake[3]: *** Waiting for unfinished jobs....
make/Main.gmk:162: recipe for target 'java.base-copy' failed
gmake[2]: *** [java.base-copy] Error 1
gmake[2]: *** Waiting for unfinished jobs..

@0xdaryl
Copy link
Contributor

0xdaryl commented Feb 12, 2019

Jenkins test sanity xlinux jdk11

@0xdaryl
Copy link
Contributor

0xdaryl commented Feb 12, 2019

Jenkins test sanity xlinuxlargeheap jdk11

@0xdaryl 0xdaryl self-assigned this Feb 12, 2019
@0xdaryl 0xdaryl changed the title compiler: build: allow dollars in identifiers allow dollars in identifiers Feb 12, 2019
@0xdaryl 0xdaryl merged commit 065a853 into eclipse-openj9:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdaryl 0xdaryl 0xdaryl approved these changes

Assignees

@0xdaryl 0xdaryl

Labels
comp:build comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwy7 @0xdaryl @jjohnst-us @pshipton