Abort AOT load for field watch #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#4173 has been opened to track future AOT work for data block. |
cathyzhyi
force-pushed
the
aotfw
branch
2 times, most recently
from
ba054a7 to
39854d5
Compare
When reporting field read/write JIT code needs to pass a data block containing data like fieldAddress, offset and owning method. Proper AOT support needs to be implemented. For now, an AOT compilation exception is added to abort AOT compilation for field watch. Code throwing the exception in ilgen when generating rdbar/wrtbar can be changed to check only AOT without SVM once the proper support is completed. Signed-off-by: Yi Zhang <yizhang@ca.ibm.com>
|
@dsouzai could you do a review? |
|
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
Closed
5 tasks
|
Some tests are skipped but there is no failing test. I am not sure why it shows the build failed. |
|
I think something went wrong from the get go, because I recall seeing an X even when the build was still running. |
|
Jenkins test sanity win jdk11 |
|
All green and approved - look fine to me too. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reporting field read/write JIT code needs to pass a data block
containing data like fieldAddress, offset and owning method. Proper AOT
support needs to be implemented.
For now, an AOT compilation exception is added to abort AOT compilation
for field watch. Code throwing the exception in ilgen when generating
rdbar/wrtbar can be changed to check only AOT without SVM once the
proper support is completed.
Signed-off-by: Yi Zhang yizhang@ca.ibm.com