Verify type of MethodHandle.catchException()'s exType argument

[pdbain-ibm]

Verify that a Throwable class is provided.

Fixes #3271

Signed-off-by: Peter Bain peter_bain@ca.ibm.com

[DanHeidinga]

lgtm

[DanHeidinga]

Jenkins test all xlinux jdk8,jdk11

[pdbain-ibm]

@DanHeidinga
Thank you for the review.
The sanity check failed compiling DDR:

23:37:52 Unhandled structure type: _IO_FILEPointer->_lock _IO_lock_t*
23:37:52 Unhandled structure type: big_int_unionPointer->i128 __int128
23:37:52 Exception in thread "main" java.lang.RuntimeException: Unexpected SRP reference type: -1 from J9SRP(J9ROMClassTOCEntry)
23:37:52 	at com.ibm.j9ddr.tools.PointerGenerator.writeSRPMethod(PointerGenerator.java:1215)

which should be completely unrelated to this change. I have rebased the change and updated the pull request in case my branch was stale.

Would you kindly resubmit the sanity build?

[DanHeidinga]

Jenkins test all xlinux jdk8,jdk11

[pdbain]

Still seeing the same failure in the test builds: compilation failure in DDR:

superset directory name : /home/jenkins/workspace/PullRequest-Extended-JDK8-linux_x86-64_cmprssptrs-OpenJ9/build/linux-x86_64-normal-server-release/vm/
superset file name : superset.dat
superset directory name : /home/jenkins/workspace/PullRequest-Extended-JDK8-linux_x86-64_cmprssptrs-OpenJ9/build/linux-x86_64-normal-server-release/vm/
superset file name : superset.dat
Writing generated classes to /home/jenkins/workspace/PullRequest-Extended-JDK8-linux_x86-64_cmprssptrs-OpenJ9/openj9/debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/pointer/generated
Writing generated classes to /home/jenkins/workspace/PullRequest-Extended-JDK8-linux_x86-64_cmprssptrs-OpenJ9/openj9/debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/structure
Unhandled structure type: _IO_FILEPointer->_lock _IO_lock_t*
Unhandled structure type: big_int_unionPointer->i128 __int128
Processing complete
Exception in thread "main" java.lang.RuntimeException: Unexpected SRP reference type: -1 from J9SRP(J9ROMClassTOCEntry)
	at com.ibm.j9ddr.tools.PointerGenerator.writeSRPMethod(PointerGenerator.java:1215)
	at com.ibm.j9ddr.tools.PointerGenerator.generateImplementationMethods(PointerGenerator.java:567)
	at com.ibm.j9ddr.tools.PointerGenerator.generateClass(PointerGenerator.java:329)
	at com.ibm.j9ddr.tools.PointerGenerator.generateClasses(PointerGenerator.java:157)
	at com.ibm.j9ddr.tools.PointerGenerator.main(PointerGenerator.java:117)

@keithc-ca could you help here? This changes only Java, which should not affect DDR, correct?
Thank you
-p

[keithc-ca]

This may be due to the compiler in use (to my knowledge, we've never fully tested gcc 5.x):

00:05:16.775 * Toolchain:      gcc (GNU Compiler Collection)
00:05:16.775 * C Compiler:     Version 5.5.0 (at /usr/bin/gcc)
00:05:16.775 * C++ Compiler:   Version 5.5.0 (at /usr/bin/g++)

[DanHeidinga]

Jenkins test all xlinux jdk8

[pdbain-ibm]

The Java 8 sanity tests are proceeding much better. Would you like an issue opened for the DDR issue?

[keithc-ca]

Unless we intend to support gcc 5.x, there's no need for a DDR issue.

[DanHeidinga]

Unless we intend to support gcc 5.x

Agreed. We're not planning to support gcc 5.x (moving to gcc 7.3!) so if this just a compiler issue, then no new issue is needed.