Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable thrstatetest on OSX #4149

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Enable thrstatetest on OSX #4149

merged 1 commit into from
Jan 16, 2019

Conversation

babsingh
Copy link
Contributor

Reverts #4082. #3878 is fixed by eclipse-omr/omr#3356.

Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

@babsingh
Enable thrstatetest on OSX
f875b94 
Reverts eclipse-openj9#4082. eclipse-openj9#3878 is fixed by
eclipse-omr/omr#3356.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Copy link
Contributor Author

fyi - @DanHeidinga @pshipton @llxia. This PR depends on eclipse-omr/omr#3356.

@DanHeidinga
Copy link
Member

Jenkins test sanity osx jdk8 depends eclipse-omr/omr#3356

@DanHeidinga
Copy link
Member

Jenkins test sanity osx jdk11 depends eclipse-omr/omr#3356

@DanHeidinga
Copy link
Member

thrstatetest passed in the jdk8 build. Failures are SCC-related:

Test result: FAILED
 [ERR] JVMSHRC659E An error has occurred while opening shared memory
 [ERR] JVMSHRC336E Port layer error code = -393970
 [ERR] JVMSHRC337E Platform error message: shmget : Cannot allocate memory
 [ERR] JVMSHRC029E Not enough memory left on the system
 [ERR] JVMSHRC663I Error recovery: destroyed semaphore set with id=655389 associated with shared class cache.
 [ERR] JVMJ9VM015W Initialization error for library j9shr29(11): JVMJ9VM009E J9VMDllMain failed
 [ERR] Error: Could not create the Java Virtual Machine.
 [ERR] Error: A fatal exception has occurred.

@llxia
Copy link
Contributor

llxia commented Dec 28, 2018

I think shmget : Cannot allocate memory failure is related to #3947

@llxia llxia mentioned this pull request Dec 28, 2018
Closed
@DanHeidinga DanHeidinga added the depends:omr Pull request is dependent on a corresponding change in OMR label Dec 31, 2018
@DanHeidinga DanHeidinga changed the title Enable thrstatetest on OSX WIP: Enable thrstatetest on OSX Dec 31, 2018
@DanHeidinga
Copy link
Member

Marking this as WIP until the OMR PR is merged and promoted

DanHeidinga
DanHeidinga approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@babsingh babsingh mentioned this pull request Jan 9, 2019
Merged
@babsingh babsingh changed the title WIP: Enable thrstatetest on OSX Enable thrstatetest on OSX Jan 14, 2019
@babsingh
Copy link
Contributor Author

fyi @DanHeidinga
Removed WIP since eclipse-omr/omr#3356 (OMR PR) has been merged. The changes have promoted to eclipse/openj9-omr's openj9 branch. So, this PR can now be merged.

@DanHeidinga
Copy link
Member

Jenkins test sanity osx jdk11

@DanHeidinga
Copy link
Member

Jenkins test sanity osx jdk8

@DanHeidinga DanHeidinga self-assigned this Jan 14, 2019
@DanHeidinga
Copy link
Member

Jenkins test sanity osx jdk8

@babsingh
Copy link
Contributor Author

@DanHeidinga All CI jobs have passed. This PR can be merged.

@DanHeidinga DanHeidinga merged commit db1cc54 into eclipse-openj9:master Jan 16, 2019
@babsingh babsingh deleted the revert-4082-test branch August 17, 2020 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanHeidinga DanHeidinga DanHeidinga approved these changes

Assignees

@DanHeidinga DanHeidinga

Labels
comp:test depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babsingh @DanHeidinga @llxia