Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder interpreter jump targets for performance #4133

Merged
merged 1 commit into from
Jan 1, 2019

Conversation

pdbain-ibm
Copy link
Contributor

@pdbain-ibm pdbain-ibm commented Dec 20, 2018

Make the order of the JUMP_TARGETs match the bytecode numbers
better.

This causes an approximately 2% improvement in Liberty startup time with -Xint
on Linux PPC.

Signed-off-by: Peter Bain peter_bain@ca.ibm.com

@DanHeidinga
Copy link
Member

@pdbain-ibm Can you add the signed-off by tag to your commit?

Please also add context on how this was found, the performance difference seen with & without it, etc. I understand there may be details that can't be shared due to the test cases used, but that shouldn't prevent sharing the improvement seen by making this change and the platforms its been tested on.

@pdbain-ibm pdbain-ibm force-pushed the reorder_iincw branch 3 times, most recently from c12f139 to b8dd888 Compare December 20, 2018 19:05
@pdbain-ibm
Copy link
Contributor Author

pdbain-ibm commented Dec 20, 2018

@DanHeidinga Done. Let me know if you want more details.

@DanHeidinga
Copy link
Member

@pdbain-ibm Has this change been tested on any other platforms?

@DanHeidinga
Copy link
Member

Jenkins test sanity plinux,zlinux,win jdk8

@DanHeidinga DanHeidinga self-assigned this Dec 20, 2018
@pdbain-ibm
Copy link
Contributor Author

@DanHeidinga do you mean for performance? If so, no.

Make the order of the JUMP_TARGETs, specifically the custom "iincw" bytecode,
match the bytecode numbers better.  This causes an approximately 2% improvement
in Liberty startup time with -Xint on Linux PPC.

Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
@DanHeidinga
Copy link
Member

Jenkins test sanity plinux,zlinux,win jdk8

@gacholio gacholio merged commit 9f2ea2c into eclipse-openj9:master Jan 1, 2019
@DanHeidinga
Copy link
Member

@pdbain-ibm Did you get the performance results with this change from the other platforms? Would be good to record that here if possible

@pdbain-ibm
Copy link
Contributor Author

Our internal performance team reports:

The iincw changes have been merged. Xint performance has improved as a result. Testing was done for Linux x86 and PPCLE64 with no ill effects observed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants