-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder interpreter jump targets for performance #4133
Conversation
@pdbain-ibm Can you add the signed-off by tag to your commit? Please also add context on how this was found, the performance difference seen with & without it, etc. I understand there may be details that can't be shared due to the test cases used, but that shouldn't prevent sharing the improvement seen by making this change and the platforms its been tested on. |
c12f139
to
b8dd888
Compare
@DanHeidinga Done. Let me know if you want more details. |
@pdbain-ibm Has this change been tested on any other platforms? |
Jenkins test sanity plinux,zlinux,win jdk8 |
@DanHeidinga do you mean for performance? If so, no. |
Make the order of the JUMP_TARGETs, specifically the custom "iincw" bytecode, match the bytecode numbers better. This causes an approximately 2% improvement in Liberty startup time with -Xint on Linux PPC. Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
b8dd888
to
21fa283
Compare
Jenkins test sanity plinux,zlinux,win jdk8 |
@pdbain-ibm Did you get the performance results with this change from the other platforms? Would be good to record that here if possible |
Our internal performance team reports:
|
Make the order of the JUMP_TARGETs match the bytecode numbers
better.
This causes an approximately 2% improvement in Liberty startup time with -Xint
on Linux PPC.
Signed-off-by: Peter Bain peter_bain@ca.ibm.com