Ensure boolean JNI methods on x86 produce a result of zero or one #4086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
hzongaro
commented
Dec 18, 2018
hzongaro
changed the title
In calling a JNI boolean method, if the native implementation returns zero, the result is false; if it returns a non-zero value, the result is true. This behaviour is consistent with the reference implementation. Progresses issue eclipse-openj9#2049 Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
|
@0dvictor can you review the x86 changes please? |
0dvictor
reviewed
Dec 20, 2018
0dvictor
suggested changes
Dec 20, 2018
0dvictor
reviewed
Dec 20, 2018
|
Jenkins test sanity xlinux,win jdk8,jdk11 |
|
I will collapse these changes into a single commit |
|
Jenkins test sanity xlinux,win jdk8,jdk11 |
hzongaro
changed the title
|
No new sanity failures - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In calling a JNI boolean method, if the native implementation returns
zero, the result is false; if it returns a non-zero value, the result
is true.
This behaviour is consistent with the reference implementation.
Progresses issue #2049
Signed-off-by: Henry Zongaro zongaro@ca.ibm.com