Add static symbol for constant pool address #4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyzhyi
force-pushed
the
symbol
branch
2 times, most recently
from
ff42e00 to
3fa6476
Compare
cathyzhyi
changed the title
cathyzhyi
force-pushed
the
symbol
branch
2 times, most recently
from
6a7fd04 to
4792d78
Compare
cathyzhyi
changed the title
Create a static symbol to represent the constant pool address for a resolved method so that a loadaddr node can be created when the CP address is needed in trees and AOT can relocate the address value correctly. Signed-off-by: Yi Zhang <yizhang@ca.ibm.com>
|
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
|
FYI any concerns a @dsouzai ? |
I can't tell from just this commit whether that's true. Is there code somewhere already where you check that this |
Closed
5 tasks
the check for CP Address is in this PR eclipse-omr/omr#3334 |
dsouzai
approved these changes
Jan 2, 2019
There was a problem hiding this comment.
With eclipse-omr/omr#3334 the AOT side of things make sense, so LGTM.
|
the failure is due to a known issue #4135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a static symbol to represent the constant pool address for a
resolved method so that a loadaddr node can be created when the CP
address is needed in trees and AOT can relocate the address value
correctly.
Signed-off-by: Yi Zhang yizhang@ca.ibm.com