Guarantee functional correctness of rdbar/wrtbar #4009
Conversation
cathyzhyi
changed the title
cathyzhyi
changed the title
cathyzhyi
force-pushed
the
functional
branch
from
8f6e4bf to
effc3af
Compare
| // 1. In Guarded Storage, we can't not do a guarded load because the object that is loaded may | ||
| // not be in the root set, and as a consequence, may get moved. | ||
| // 2. For read barriers, the vmhelpers are GC points and therefore the object might be moved | ||
| if (TR::Compiler->om.shouldGenerateReadBarriersForFieldLoads() || generateReadBarrier) |
There was a problem hiding this comment.
why isn't the first part of this || part of the bool added above? it would seem you would have to repeat this idiom no? Doesn't this warrant a trace statement of some kind to say we disabling because of this?
There was a problem hiding this comment.
Cleaned up the bool and condition. Added tracing as well.
cathyzhyi
force-pushed
the
functional
branch
from
effc3af to
61902f3
Compare
| @@ -2302,6 +2302,9 @@ TR_CISCNode * | |||
| TR_CISCTransformer::addAllSubNodes(TR_CISCGraph *const graph, TR::Block *const block, TR::TreeTop *const top, | |||
| TR::Node *const parent, TR::Node *const node, const int32_t dagId) | |||
| { | |||
| //IdiomRecognition doesn't know how to handle rdbar/wrtbar for now | |||
| if ((node->getOpCode().isReadBar() || node->getOpCode().isWrtBar()) && comp()->incompleteOptimizerSupportForReadWriteBarriers()) | |||
There was a problem hiding this comment.
can we reverse the order of the && to make this more clear and break onto a new line at the && so it looks more like
&& (node->getOpCode().isReadBar() || node->getOpCode().isWrtBar()))
There was a problem hiding this comment.
changed according to the comment. Thanks!
|
Once the final code formatting issue is sorted I think this will be good to test and merge. |
cathyzhyi
force-pushed
the
functional
branch
2 times, most recently
from
03bdb7b to
9485589
Compare
This change guarantee the correctness of rdbar/wrtbar from the following aspects: 1. Consider rdbar/wrtbar as GC points 2. Make optimizations consider shape of rdbar/wrtbar when doing transformations 3. Disable opts not supporting newly added rdbar/wrtbar when seeing the opcodes Signed-off-by: Yi Zhang <yizhang@ca.ibm.com>
|
Changed the coding format issue and also added code to disable escape analysis. |
|
Jenkins test sanity xlinux,win,plinux jdk8.jdk11 |
|
Jenkins test sanity xlinux,win,plinux jdk8,jdk11 |
|
Failure on x86-64 is DDR related and unrelated to this change- merging |
This change guarantees the correctness of rdbar/wrtbar from the following
aspects:
transformations
the opcodes
Signed-off-by: Yi Zhang yizhang@ca.ibm.com