Improve MethodHandles.lookup() field accesses #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform loader constraints check when accessing a field via a FindGetter or FindSetter MethodHandle. This applies to both instance and static fields. Added tests to check IllegalAccessException with LinkageError cause thrown in following cases: MH instance/static field getter/setter for reference and type classes loaded by different class loaders MH instance/static field getter/setter for reference/type and access classes loaded by different class loaders Signed-off-by: Jason Feng <fengj@ca.ibm.com>
|
Jenkins test sanity xlinux jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
MethodHandles.lookup()field accessesPerform loader constraints check when accessing a field via a
FindGetterorFindSetterMethodHandle. This applies to bothinstanceandstaticfields.Added tests to check
IllegalAccessExceptionwithLinkageErrorcause thrown in following cases:MH instance/static field getter/setterforreferenceandtypeclasses loaded by different class loadersMH instance/static field getter/setterforreference/typeandaccessclasses loaded by different class loadersReviewer: @DanHeidinga
Signed-off-by: Jason Feng fengj@ca.ibm.com