Deprecate ShrinkWrapping - Part III #3291
Conversation
|
Changes are rather simple but wouldn't hurt a review from either @gacholio or @keithc-ca given changes in their area of expertise. FYI this removes the last bit of code related to shrink wrapping in OpenJ9 (AFAIK). |
|
Looks reasonable to me - I don't think you should edit the DDR artifacts. @keithc-ca ? |
Yeah I was wondering about that. Is there a reason for those files to exist in OpenJ9? There seems to be like 40 spec files each with over 10k lines of "stuff". That's more lines together than the entire JIT compiler for example. Takes up a few mbs of space too in the repo. |
|
The changes to files in |
|
I don't know what 'shrink wrapping' means in this context, but if any JVM based on OpenJ9 exists that might generate a core file to be examined, the support for interpreting such core files should remain. |
Ok, I'll revert the spec changes then. On another note if these files have no effect on OpenJ9 builds can we migrate them to the IBM internal repo that cares about them? Why pollute the open source repo if the files are meaningless? Should we open up an issue for this? If you can specify which files can be migrated I will gladly do the work. Edit: It also makes filtering through the noise harder when searching for something in the repo as for pretty much any C++ entity there will be a search result in each and every one of these spec files. |
fjeremic
force-pushed
the
remove-shrink-wrapping-part-iii
branch
from
b853987 to
7d4469a
Compare
|
Jenkins test sanity all JDK8 |
| * the save offset is located from bits 18-32 | ||
| * so first mask it off to get the bit vector | ||
| * corresponding to the saved GPRS | ||
| */ |
There was a problem hiding this comment.
Could you please fix the indentation of this comment so is consistent?
fjeremic
force-pushed
the
remove-shrink-wrapping-part-iii
branch
from
7d4469a to
19913fe
Compare
Remove some last bits and pieces of Shrink Wrapping code in the stack walker. Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
|
Jenkins test sanity all JDK11 Launching again because the record of whether the previous PR build was successful was lost on the last push, and I did not see the results. |
Remove some last bits and pieces of Shrink Wrapping code in the stack
walker.
Issue: eclipse-omr/omr#2107
Signed-off-by: Filip Jeremic fjeremic@ca.ibm.com